Packages/php-codesniffer
2
0
Fork 0
Code Issues Pull requests Releases Activity

Compare commits

base: Packages:42a7968ceecd348ca14bb00c7bd6105d1845afa5
Branches Tags
Packages:master
..
compare: Packages:d2e164d5e5a4e2a4bfb640a5afd5e01993a12de8
Branches Tags
Packages:master

2 commits
42a7968cee ... d2e164d5e5

Author SHA1 Message Date
Ferdinand Kuhl
d2e164d5e5 fix possible bug in restoring the original severity if ignoring parent errors
All checks were successful
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/push/code-style Pipeline was successful
Details
2023-02-14 12:24:55 +01:00
Ferdinand Kuhl
d5831242f5 allow missing @var annotations 2023-02-14 12:24:27 +01:00
2 changed files with 2 additions and 2 deletions
Show stats Expand all files Collapse all files

2
src/DigiComp/Sniffs/Commenting/VariableCommentSniff.php
View file

@ -57,7 +57,7 @@ class VariableCommentSniff extends \PHP_CodeSniffer\Standards\Squiz\Sniffs\Comme
$oldSeverity = $phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity'] ?? null; $oldSeverity = $phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity'] ?? null;
$phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity'] = 0; $phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity'] = 0;
parent::processMemberVar($phpcsFile, $stackPtr); parent::processMemberVar($phpcsFile, $stackPtr);
if ($oldSeverity) { if ($oldSeverity !== null) {
$phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity'] = $oldSeverity; $phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity'] = $oldSeverity;
} else { } else {
unset($phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity']); unset($phpcsFile->ruleset->ruleset['DigiComp.Commenting.VariableComment.Missing']['severity']);

2
src/DigiComp/ruleset.xml
View file

@ -17,7 +17,7 @@
<exclude name="DigiComp.Commenting.VariableComment.MissingVar" /> <exclude name="DigiComp.Commenting.VariableComment.MissingVar" />
</rule> </rule>
<!-- TODO: what about new PHP 7.4 code base, where property annotations may get useless? --> <!-- TODO: what about new PHP 7.4 code base, where property annotations may get useless? -->
<rule ref="DigiComp.Commenting.VariableComment.MissingVar"> <rule ref="DigiComp.Commenting.VariableComment.Missing">
<type>warning</type> <type>warning</type>
<severity>4</severity> <severity>4</severity>
</rule> </rule>