From aaeb2d5c7f795959c407ce4bb082022a64684aef Mon Sep 17 00:00:00 2001 From: Robin Krahnen Date: Tue, 3 Apr 2018 10:29:06 +0200 Subject: [PATCH 1/4] just some annotation cleanup --- Classes/Validation/Validator/SettingsValidator.php | 1 + 1 file changed, 1 insertion(+) diff --git a/Classes/Validation/Validator/SettingsValidator.php b/Classes/Validation/Validator/SettingsValidator.php index 1db1d4c..dec549f 100644 --- a/Classes/Validation/Validator/SettingsValidator.php +++ b/Classes/Validation/Validator/SettingsValidator.php @@ -163,6 +163,7 @@ class SettingsValidator extends AbstractValidator * Check whether at least one configured group does match, if any is configured. * * @param array $validatorConfig + * * @return bool */ protected function doesValidationGroupsMatch(array &$validatorConfig) From 6922dba2a98d21f8e820e8e4ceb428ea1ecfb302 Mon Sep 17 00:00:00 2001 From: Robin Krahnen Date: Tue, 3 Apr 2018 17:53:57 +0200 Subject: [PATCH 2/4] add quotes around strings in YAML files --- Configuration/Testing/Validation.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Configuration/Testing/Validation.yaml b/Configuration/Testing/Validation.yaml index e61cfb0..45d895e 100644 --- a/Configuration/Testing/Validation.yaml +++ b/Configuration/Testing/Validation.yaml @@ -16,12 +16,12 @@ TrueValidator: DigiComp\SettingValidator\Tests\Functional\Fixtures\TestValidationGroupsCustomObject: self: DigiComp.SettingValidator:Settings: - name: GroupValidatorCustom + name: 'GroupValidatorCustom' DigiComp\SettingValidator\Tests\Functional\Fixtures\TestValidationGroupsDefaultObject: self: DigiComp.SettingValidator:Settings: - name: GroupValidatorDefault + name: 'GroupValidatorDefault' GroupValidatorDefault: properties: @@ -35,4 +35,4 @@ GroupValidatorCustom: BooleanValue: expectedValue: false validationGroups: - - Custom + - 'Custom' From ab79cc0e147c86da2408e7baf26bb33c21773252 Mon Sep 17 00:00:00 2001 From: Robin Krahnen Date: Thu, 5 Apr 2018 09:02:15 +0200 Subject: [PATCH 3/4] replaced doctype annotation in methods with comment --- Classes/Package.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/Package.php b/Classes/Package.php index 06276a7..b4026d1 100644 --- a/Classes/Package.php +++ b/Classes/Package.php @@ -32,7 +32,7 @@ class Package extends BasePackage $dispatcher = $bootstrap->getSignalSlotDispatcher(); $dispatcher->connect(ConfigurationManager::class, 'configurationManagerReady', function ($configurationManager) { - /** @var ConfigurationManager $configurationManager */ + /* @var ConfigurationManager $configurationManager */ $configurationManager->registerConfigurationType( static::CONFIGURATION_TYPE_VALIDATION, ConfigurationManager::CONFIGURATION_PROCESSING_TYPE_DEFAULT, From 24435642721633663449837f9865ad5f25253c9e Mon Sep 17 00:00:00 2001 From: Robin Krahnen Date: Thu, 5 Apr 2018 10:28:15 +0200 Subject: [PATCH 4/4] remove unused imports --- Tests/Functional/Fixtures/TestValidationGroupsCustomObject.php | 2 -- Tests/Functional/Fixtures/TestValidationGroupsDefaultObject.php | 2 -- 2 files changed, 4 deletions(-) diff --git a/Tests/Functional/Fixtures/TestValidationGroupsCustomObject.php b/Tests/Functional/Fixtures/TestValidationGroupsCustomObject.php index 29df333..9fa7227 100644 --- a/Tests/Functional/Fixtures/TestValidationGroupsCustomObject.php +++ b/Tests/Functional/Fixtures/TestValidationGroupsCustomObject.php @@ -1,8 +1,6 @@